chore: add telemetry realworld app #26896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+57
to
+58
| if (this.requirementsToExport === 'unknown') { | ||
| this.requirementsToExport = 'unmet' |
There was a problem hiding this comment.
why do we need unknown and unmet? can we assume 'unmet' until met?
There was a problem hiding this comment.
any reason this wasn't a bool?
There was a problem hiding this comment.
when encryption is on, we can't assume unmet until we get a null project id or record key. The send function will behave differently. If unmet we error instantly, if unknown we will delay the request.
There was a problem hiding this comment.
Otherwise we could incorrectly fail any spans sent prior to getting the project id/record key, since we capture spans prior to them being available.
There was a problem hiding this comment.
makes sense, maybe we throw a comment in there about this? unless I missed it per the limited diff view 😅
| @@ -822,7 +822,7 @@ commands: | |||
| name: Run tests using browser "<<parameters.browser>>" | |||
| working_directory: /tmp/<<parameters.repo>>/<<parameters.folder>> | |||
| command: | | |||
| <<parameters.command>> -- --browser <<parameters.browser>> | |||
| <<parameters.command>> --browser <<parameters.browser>> --record false | |||
There was a problem hiding this comment.
was recording disabled to test this? or are you intentionally disabling?
Also not in this scope per-say, but do you know whats different between the test-binary-against-rwa and test-binary-against-repo jobs? test-binary-against-rwa seems like a copy paste?
There was a problem hiding this comment.
Recording was never enabled, but i needed to override the project ID and record key to send telemetry. I disabled recording to silence a warning thrown when record is not enabled.
I don't know the different between test-binary-against-repo, I didn't notice they were the same.
There was a problem hiding this comment.
ohh I see, passing CYPRESS_PROJECT_ID prob caused that error
There was a problem hiding this comment.
Do we no longer need the double -- since the command is executed with yarn?
There was a problem hiding this comment.
Yeah, yarn kept yelling at me about it.
emilyrohrbough
approved these changes
Jun 1, 2023
AtofStryker
approved these changes
Jun 1, 2023
| @@ -822,7 +822,7 @@ commands: | |||
| name: Run tests using browser "<<parameters.browser>>" | |||
| working_directory: /tmp/<<parameters.repo>>/<<parameters.folder>> | |||
| command: | | |||
| <<parameters.command>> -- --browser <<parameters.browser>> | |||
| <<parameters.command>> --browser <<parameters.browser>> --record false | |||
There was a problem hiding this comment.
Do we no longer need the double -- since the command is executed with yarn?
3 tasks
mjhenkes
added a commit
that referenced
this pull request
Jun 2, 2023
* chore: add Nx Cloud (#26712) * chore: add empty nx.json [run ci] * chore: add nx cloud runner [run ci] * chore: add nx-cloud dep [run ci] * chore: update local nx cloud accessToken to be read-only * feat: update git related messages for runs and debug (#26758) * feat(app): update DebugError copy * feat: set isUsingGit project flag and consume in DebugContainer * feat(app): update not using git icon for DebugError * feat(app): displays alert on runs page when not using git * feat(app): add component for when no runs for current branch * feat(app): add warning for no runs for branch on runs container * chore: add feat to CHANGELOG * chore: remove logged status value * chore: resolve import from merge conflict * test(app): stub branch name for e2e runs spec * chore: add line break in changelog entry * chore: cleanup PR * chore: fix i18n import for DebugBranchError * chore: add utm and update Warning links to inline * chore: capitalize Git in i18n * ref: warning liink * test: add i18n to tests * test(app): change utm_source assertions * chore: cleanup pr * chore: remove unused prop * test(app): remove no git warning when moving to runs page in e2e * chore: change template logic * chore: remove duplicate RUNS_TAB_MEDIUM const * Changed Debug test assertion and reordered new components for Debug --------- Co-authored-by: Stokes Player <[email protected]> * chore: rename video processing events to capture/compress (#26800) * chore: change processing nomenclature to compressing when printing the run. * chore: rename 'capturing of' to 'capturing' * chore: rename upload results to upload screenshots & videos (#26811) * chore: rename upload results to upload screenshots & videos * run ci * chore: capture versions of relevant dependencies with `x-dependencies` header (#26814) * chore: update changlelog script to handle revert pr ref (#26801) * fix: Correct typescript scaffold dependency (#26815) * fix: correct typescript scaffold dependency (#26204) * add changelog * Update change log for PR comment Co-authored-by: Mike Plummer <[email protected]> --------- Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Mark Noonan <[email protected]> * chore: 12.13.0 prep (#26833) * chore: 12.13.0 release (#26834) * chore: 12.13.0 changelog fix * remove pending, bump version * fix typo * chore: release @cypress/vite-plugin-cypress-esm-v1.0.1 [skip ci] * chore: Implement runSpec mutation (#26782) * chore: replace gitter badge with discord on readme (#26771) * chore: add GraphQL mutation for sending system notifications via Electron (#26773) * fix: upgrade typescript from 4.7.4 to 4.9.5 (#26826) Snyk has created this PR to upgrade typescript from 4.7.4 to 4.9.5. See this package in npm: See this project in Snyk: https://app.snyk.io/org/cypress-opensource/project/d5b36925-e6ee-455d-9649-6560a9aca413?utm_source=github&utm_medium=referral&page=upgrade-pr * test: fix 2 broken tests for Windows (#26854) * Update stale_issues_and_pr_cleanup.yml Upped the number of operations per run. Have been manually doing that so this job can get through all the issues in the repo with no problems. * chore(dep): [Snyk] Upgrade vite from 2.9.13 to 2.9.15 (#26830) Co-authored-by: Ben M <[email protected]> * Update triage_add_to_project.yml * chore: fix minor background color styling in debug results component (#26887) * Update stale_issues_and_pr_cleanup.yml stalebot was incorrectly configured to run in debug mode. I have updated the default to run in normal mode when running scheduled * chore: Deprecate @cypress/xpath package (#26893) * chore: add telemetry realworld app (#26896) * chore: capture telemetry for realworld app maybe * idk what i was doing * setup record key and telemetry * testing * override project id * some times we just need a little context. * Adding tests * Adding comment * fix yarn lock * Trying this.... * fix tests? --------- Co-authored-by: Jordan <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Bill Glesias <[email protected]> Co-authored-by: Adam Stone-Lord <[email protected]> Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Dave Kasper <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Mark Noonan <[email protected]> Co-authored-by: Chris Breiding <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Ely Lucas <[email protected]> Co-authored-by: Snyk bot <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Ben M <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]>
mjhenkes
added a commit
that referenced
this pull request
Jun 2, 2023
* chore: add Nx Cloud (#26712) * chore: add empty nx.json [run ci] * chore: add nx cloud runner [run ci] * chore: add nx-cloud dep [run ci] * chore: update local nx cloud accessToken to be read-only * feat: update git related messages for runs and debug (#26758) * feat(app): update DebugError copy * feat: set isUsingGit project flag and consume in DebugContainer * feat(app): update not using git icon for DebugError * feat(app): displays alert on runs page when not using git * feat(app): add component for when no runs for current branch * feat(app): add warning for no runs for branch on runs container * chore: add feat to CHANGELOG * chore: remove logged status value * chore: resolve import from merge conflict * test(app): stub branch name for e2e runs spec * chore: add line break in changelog entry * chore: cleanup PR * chore: fix i18n import for DebugBranchError * chore: add utm and update Warning links to inline * chore: capitalize Git in i18n * ref: warning liink * test: add i18n to tests * test(app): change utm_source assertions * chore: cleanup pr * chore: remove unused prop * test(app): remove no git warning when moving to runs page in e2e * chore: change template logic * chore: remove duplicate RUNS_TAB_MEDIUM const * Changed Debug test assertion and reordered new components for Debug --------- Co-authored-by: Stokes Player <[email protected]> * chore: rename video processing events to capture/compress (#26800) * chore: change processing nomenclature to compressing when printing the run. * chore: rename 'capturing of' to 'capturing' * chore: rename upload results to upload screenshots & videos (#26811) * chore: rename upload results to upload screenshots & videos * run ci * chore: capture versions of relevant dependencies with `x-dependencies` header (#26814) * chore: update changlelog script to handle revert pr ref (#26801) * fix: Correct typescript scaffold dependency (#26815) * fix: correct typescript scaffold dependency (#26204) * add changelog * Update change log for PR comment Co-authored-by: Mike Plummer <[email protected]> --------- Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Mark Noonan <[email protected]> * chore: 12.13.0 prep (#26833) * chore: 12.13.0 release (#26834) * chore: 12.13.0 changelog fix * remove pending, bump version * fix typo * chore: release @cypress/vite-plugin-cypress-esm-v1.0.1 [skip ci] * chore: Implement runSpec mutation (#26782) * chore: replace gitter badge with discord on readme (#26771) * chore: add GraphQL mutation for sending system notifications via Electron (#26773) * fix: upgrade typescript from 4.7.4 to 4.9.5 (#26826) Snyk has created this PR to upgrade typescript from 4.7.4 to 4.9.5. See this package in npm: See this project in Snyk: https://app.snyk.io/org/cypress-opensource/project/d5b36925-e6ee-455d-9649-6560a9aca413?utm_source=github&utm_medium=referral&page=upgrade-pr * test: fix 2 broken tests for Windows (#26854) * Update stale_issues_and_pr_cleanup.yml Upped the number of operations per run. Have been manually doing that so this job can get through all the issues in the repo with no problems. * chore(dep): [Snyk] Upgrade vite from 2.9.13 to 2.9.15 (#26830) Co-authored-by: Ben M <[email protected]> * Update triage_add_to_project.yml * chore: fix minor background color styling in debug results component (#26887) * Update stale_issues_and_pr_cleanup.yml stalebot was incorrectly configured to run in debug mode. I have updated the default to run in normal mode when running scheduled * chore: Deprecate @cypress/xpath package (#26893) * chore: add telemetry realworld app (#26896) * chore: capture telemetry for realworld app maybe * idk what i was doing * setup record key and telemetry * testing * override project id * some times we just need a little context. * Adding tests * Adding comment * chore(deps): update dependency find-process to v1.4.7 🌟 (#26906) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <[email protected]> * chore(deps): update dependency firefox-profile to v4.3.2 🌟 (#26912) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jennifer Shehane <[email protected]> --------- Co-authored-by: Jordan <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Bill Glesias <[email protected]> Co-authored-by: Adam Stone-Lord <[email protected]> Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Dave Kasper <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Mark Noonan <[email protected]> Co-authored-by: Chris Breiding <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Ely Lucas <[email protected]> Co-authored-by: Snyk bot <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Ben M <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This PR enables telemetry for the
test-binary-against-cypress-realworld-appjob in CI. We will use this job as a performance baseline.This change also exposed an issue when having telemetry enabled during a 'cypress verify' workflow. Since the project id and record key were not, nor would ever be specified the exporter would time out waiting to send the spans. Unfortunately that timeout is longer than the verify timeout and so verify would fail.
The fix is to fail sending spans fast if encryption is required and we will not get a record key or a project id.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?